[Test] Add selector algorithm E2E coverage foundation - #3527
Open
LiXuanqi wants to merge 4 commits into
Open
Conversation
Signed-off-by: LiXuanqi <lixuanqi1995@gmail.com>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
pr/needs-author
Signed-off-by: LiXuanqi <lixuanqi1995@gmail.com>
LiXuanqi
marked this pull request as ready for review
September 6, 2026 09:04
LiXuanqi
requested review from
AayushSaini101,
FAUST-BENCHOU,
WUKUNTAI-0211,
drivebyer,
ramkrishs,
shraderdm,
theohsiung and
wilsonwu
as code owners
September 6, 2026 09:04
Author
github-actions
Bot
added
pr/blocked
Xunzhuo
requested changes
Sep 6, 2026
Xunzhuo
left a comment
Xunzhuo
left a comment
Member
There was a problem hiding this comment.
Thanks for laying out the selector coverage matrix. One merge blocker remains: src/semantic-router/pkg/config/routing_surface_catalog_test.go reads e2e/pkg/testcases/testdata/selector_algorithm_coverage.json, so the production config package now depends upward on the E2E tree. The exact-head structure gate rejects this as prod-code-must-not-reference-e2e-docs-or-agent-tools, and that failure also blocks the PR gate. Please keep the manifest/catalog consistency check on the E2E side, or move the shared asset to an allowed package-owned location, then rerun the exact-head checks.
Query the public runtime catalog from the router module without making config tests read E2E assets. Run the registry and coverage contracts before E2E builds so CI continues to enforce the manifest. Signed-off-by: LiXuanqi <lixuanqi1995@gmail.com>
Include the transitive test dependency checksums required by go mod tidy to unblock the dashboard CI check. Signed-off-by: LiXuanqi <lixuanqi1995@gmail.com>
github-actions
Bot
added
pr/needs-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #3179
Purpose
Establish the E2E coverage foundation for the selector algorithms tracked by #3179. The issue is accepted and owned by
wg/evaluation-quality.This PR:
DecisionAlgorithmCatalog.selector-algorithmsE2E profile with isolated Gateway and mock-vLLM resources.staticselector as the first complete example, asserting its selected decision, algorithm, and model diagnostic headers.core-selection-*cases registered until the remaining selector algorithms have replacement coverage.This is a foundation PR and intentionally does not close #3179.
Test Plan
Test Result
Passed:
make agent-validatemake test-semantic-routermake build-e2emake recipe-conformance-staticcd e2e && go test ./pkg/testcases ./profiles/all ./profiles/selector-algorithmsmake agent-ci-gate CHANGED_FILES="e2e/profiles/selector-algorithms/values.yaml"make e2e-test E2E_PROFILE=selector-algorithmsusing the CI-pinned Kind node image (kindest/node:v1.33.7): 1 test passed, 0 failed (selector-static).Semantic Router PR Checklist
[Feature],[Bug],[Docs],[Test],[Research],[Community], or[CI/Build][Router][Docs]; affected modules belong in labels and the PR bodyacceptedissue with exactly one owner: onewg/*label for project work orowner/maintainersfor repository governancegit commit -sSee CONTRIBUTING.md for the full contributor workflow and commit guidance.